[
https://issues.apache.org/jira/browse/LUCENE-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14604002#comment-14604002
]
David Smiley commented on LUCENE-6578:
--------------------------------------
bq. Why not support both? The current strategy is eminently extensible, which
is what I like about it.
Sure; +1.
bq. I construed this as a generic "internal distance" method, which is how it's
used in my employer's application. Removing the genericism would bust that
application. So I prefer to leave this the way it is, thanks.
Okay; this can be handled with javadocs that explain how this shape implements
computeDistance.
I went to apply your patch but ran into some issues in doing so:
* The patch shows a class was renamed (GeoBaseShape to BasePlanetObject), yet
the patch's reference to the file does so in a way that doesn't seem right.
The "Index:" line should show the old name, the "---" line should also show the
old name, and the "+++" line should show the new name. In your patch, all 3
have the old name. This definitely confused IntelliJ, and I expect it would
confuse ReviewBoard too. I hand-edited the patch to change the first two to the
old name and that worked. How are you generating the patch?
* The patch shows GeoBaseMembershipShape (newly added) as extending
GeoBaseShape, yet that can’t be since GeoBaseShape should now be named
BasePlanetObject. I hand edited it to be BasePlanetObject; but this didn't
give me a warm and fuzzy that this patch file is ready for me to work with. ...
* GeoCircle.getBounds couldn't figure out how to call super.getBounds because
there is no superclass implementing that method, just the interface.
Can you provide a better patch Karl? Was your code compiling at the time you
generated the patch?
> Geo3d: arcDistanceToShape() method may be useful
> ------------------------------------------------
>
> Key: LUCENE-6578
> URL: https://issues.apache.org/jira/browse/LUCENE-6578
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/spatial
> Reporter: Karl Wright
> Attachments: LUCENE-6578.patch, LUCENE-6578.patch
>
>
> I've got an application that seems like it may need the ability to compute a
> new kind of arc distance, from a GeoPoint to the nearest edge/point of a
> GeoShape. Adding this method to the interface, and corresponding
> implementations, would increase the utility of the package for ranking
> purposes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
