[
https://issues.apache.org/jira/browse/SOLR-7787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14626953#comment-14626953
]
Hoss Man commented on SOLR-7787:
--------------------------------
bq. My original intention was to update HPPC which is duplicated in Solr and
the clustering contrib. These have to be consistent. From there I observed that:
...
bq. I am really ok with any option. I decided to cut fastutil out because it's
just a much larger library (of which almost nothing is practically used in
Solr). Also, hll's implementation uses fastutil iterators very inefficiently
(causing intermediate autoboxing on every value) so I thought I'd take a stab
at improving that while converting to HPPC.
Got it -- so the primary concern is/was dependency version consistency, and in
the process of going down that rabbit hole, you realized forking HLL to
eliminate the dep on fastutil seemed like the best win all around.
Sounds like a good plan of attack to me.
> Fork HyperLogLog and remove fastutil dependency
> -----------------------------------------------
>
> Key: SOLR-7787
> URL: https://issues.apache.org/jira/browse/SOLR-7787
> Project: Solr
> Issue Type: Task
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Trivial
> Fix For: 5.3, Trunk
>
>
> So fastutil is now part of Solr's distribution (because the stats component
> uses hyperloglog library, which in turn requires fastutil). I looked at the
> actual uses of fastutil and only java-hll uses it (and only a few classes).
> I've created a fork that uses HPPC instead (also randomized all tests, they
> pass). Since it's a relatively simple package I think it could be forked and
> imported into Solr's codebase entirely. I'd make a pull request but I see
> Hoss also created a few comments/ PRs and none of them received any
> attention; the project seems to be stale or dead?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
