[
https://issues.apache.org/jira/browse/SOLR-7787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14626975#comment-14626975
]
Dawid Weiss commented on SOLR-7787:
-----------------------------------
bq. Got it – so the primary concern is/was dependency version consistency, and
in the process of going down that rabbit hole, you realized forking HLL to
eliminate the dep on fastutil seemed like the best win all around.
Yes, that's exactly what happened.
bq. I wonder though would hll accept a patch to remove the dependency (or make
it optional)?
It's not a complete removal -- I simply replaced fastutil with HPPC (since Solr
already uses it in a couple of places anyway). I also did a few other changes
the author may not be too happy with (replaced testng with junit, replaced
hardcoded randomization seeds with randomizedtesting, etc.) in preparation of
importing the code into Solr's codebase. I will submit a PR too, but there
seems to be a general lack of interest in this code from the original author,
see Hoss's unaddressed question here:
https://github.com/aggregateknowledge/java-hll/issues/15
and Timon Karnezos doesn't seem to be too active recently:
https://github.com/timonk?tab=contributions&period=monthly
> Fork HyperLogLog and remove fastutil dependency
> -----------------------------------------------
>
> Key: SOLR-7787
> URL: https://issues.apache.org/jira/browse/SOLR-7787
> Project: Solr
> Issue Type: Task
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Trivial
> Fix For: 5.3, Trunk
>
>
> So fastutil is now part of Solr's distribution (because the stats component
> uses hyperloglog library, which in turn requires fastutil). I looked at the
> actual uses of fastutil and only java-hll uses it (and only a few classes).
> I've created a fork that uses HPPC instead (also randomized all tests, they
> pass). Since it's a relatively simple package I think it could be forked and
> imported into Solr's codebase entirely. I'd make a pull request but I see
> Hoss also created a few comments/ PRs and none of them received any
> attention; the project seems to be stale or dead?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
