[ https://issues.apache.org/jira/browse/LUCENE-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652029#comment-14652029 ]
Jack Conradson edited comment on LUCENE-6417 at 8/3/15 4:13 PM: ---------------------------------------------------------------- Sorry, Mike and Uwe, for the delayed response. I was actually on vacation the previous week. I'll fix the pre-commit and make the suggested changes. The ASM did not change at all (other than by mistake :) ), I was just forced to re-organize the ASM generation code into smaller chunks for the Antlr 4.5 visitor. Thanks for reviewing the patch! was (Author: jdconradson): Sorry, Mike and Uwe, for the delayed response. I was actually on vacation the previous week. I'll fix the pre-commit and make the suggested changes. The ASM did not change at all (other than by mistake :) ), I was just forced to re-organize the ASM generation code into smaller chunks for the Antler 4.5 visitor. Thanks for reviewing the patch! > Upgrade ANTLR to version 4.5 > ---------------------------- > > Key: LUCENE-6417 > URL: https://issues.apache.org/jira/browse/LUCENE-6417 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Jack Conradson > Attachments: LUCENE-6471.patch > > > I would like to upgrade ANTLR from 3.5 to 4.5. This version adds several > features that will improve the existing grammars. The main improvement would > be the allowance of left-hand recursion in grammar rules which will reduce > the number of rules significantly for expressions. > This change will require some code refactoring to the existing expressions > work. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org