[
https://issues.apache.org/jira/browse/LUCENE-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654358#comment-14654358
]
Uwe Schindler edited comment on LUCENE-6417 at 8/4/15 9:25 PM:
---------------------------------------------------------------
I was trying to fix this, but the problem is: those inner classes are now part
of public APIs (the visitors). So we must either make all visitor interfaces
and the implementations hidden, which required impl methods pkg-protected, too
(which is impossible to java: interface implementations have to be public).
Alternatively we should remove the package private stuff completely and make
everything public. But this f*cks up the API, because we wanted to have the
whole ANT-stuff package private and therefore hidden from javadocs as
implementation detail. Using the visitor interfaces, this is now impossible.
Sorry, I cannot commit this in this stage... We have to take care of this
first. Just generate the Javadocs then look at JavascriptCompiler's Javadoc and
you will see the problem.
was (Author: thetaphi):
I was trying to fix this, but the problem is: those inner classes are now part
of public APIs (the visitors). So we must either make all visitor interfaces
and the implementations hidden (and the imple methods would need to get
pkg-protected too - which is impossible to java: interface implementations have
to be public), or we should remove the package private stuff completely and
make public. But this f*cks up the API, because we wanted to have the whole
ANT-stuff package private and therefore hidden from javadocs as implementation
detail. Using the visitor interfaces, this is now impossible.
Sorry, I cannot commit this in this stage... We have to take care of this
first. Just generate the Javadocs then look at JavascriptCompiler's Javadoc and
you will see the problem.
> Upgrade ANTLR to version 4.5
> ----------------------------
>
> Key: LUCENE-6417
> URL: https://issues.apache.org/jira/browse/LUCENE-6417
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Jack Conradson
> Assignee: Uwe Schindler
> Attachments: LUCENE-6471.patch, LUCENE-6471.patch, LUCENE-6471.patch
>
>
> I would like to upgrade ANTLR from 3.5 to 4.5. This version adds several
> features that will improve the existing grammars. The main improvement would
> be the allowance of left-hand recursion in grammar rules which will reduce
> the number of rules significantly for expressions.
> This change will require some code refactoring to the existing expressions
> work.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
