[
https://issues.apache.org/jira/browse/SOLR-7855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653857#comment-14653857
]
Mark Miller commented on SOLR-7855:
-----------------------------------
+1, looks good to me.
Minor suggestions:
Assign.java - remove unused imports rather than refactor
OverseerProcessor - new file, remove unused imports
OvrseerCollectionMessageHandler -new file, remove unused imports
OverseeerMessageHandlerSelector - add light class doc
OverseerCollectionProcessor - add light class doc
OverseerProcessor - add light class doc
> OverseerCollectionProcessor: separate general task management from collection
> message handling
> ----------------------------------------------------------------------------------------------
>
> Key: SOLR-7855
> URL: https://issues.apache.org/jira/browse/SOLR-7855
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Attachments: SOLR-7855.patch, SOLR-7855.patch
>
>
> While working on SOLR-7789, I realized it would be easier if I split up the
> OverseerCollectionProcessor into two parts:
> 1) General handling of tasks (work queues, etc)
> 2) Processing a collection handler request
> I haven't decided whether the ConfigSet should have its own processor, i.e.
> OverseerConfigSetProcessor or reuse at least the thread for the
> OverseerCollectionProcessor, but in either case this refactoring will be
> helpful. That is, if the ConfigSet processing has its own processing, I can
> reuse the general handling of tasks part. If the ConfigSet processing reuses
> the OverseerCollectionProcessing thread, I won't complicate the
> implementation with ConfigSet operations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
