[
https://issues.apache.org/jira/browse/SOLR-7855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653905#comment-14653905
]
Mark Miller commented on SOLR-7855:
-----------------------------------
bq. (it doesn't really have anything to do directly with collections AFAICT,
though the CollectionProcessor handles messages about it).
Seems like someone was lazy when they added it. Don't know what to tell you
now. At least it's more isolated with this patch.
bq. package-level info
We can open that up and add internal comment notes or something if you think
that makes sense. A lot of this is probably fairly arbitrary when compared to
the rest of the code.
A lot of cloud code has already kind of cluttered up random packages as it was
added for various easy at the time reasons - moving towards something nicer
makes sense to me.
> OverseerCollectionProcessor: separate general task management from collection
> message handling
> ----------------------------------------------------------------------------------------------
>
> Key: SOLR-7855
> URL: https://issues.apache.org/jira/browse/SOLR-7855
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Attachments: SOLR-7855.patch, SOLR-7855.patch
>
>
> While working on SOLR-7789, I realized it would be easier if I split up the
> OverseerCollectionProcessor into two parts:
> 1) General handling of tasks (work queues, etc)
> 2) Processing a collection handler request
> I haven't decided whether the ConfigSet should have its own processor, i.e.
> OverseerConfigSetProcessor or reuse at least the thread for the
> OverseerCollectionProcessor, but in either case this refactoring will be
> helpful. That is, if the ConfigSet processing has its own processing, I can
> reuse the general handling of tasks part. If the ConfigSet processing reuses
> the OverseerCollectionProcessing thread, I won't complicate the
> implementation with ConfigSet operations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
