[ 
https://issues.apache.org/jira/browse/SOLR-7836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698680#comment-14698680
 ] 

Mark Miller commented on SOLR-7836:
-----------------------------------

{quote}
So: one can't call getIndexWriter() and then do anything else that will 
eventually call getIndexWriter() or newIndexWriter()
If we keep that restriction, then moving the ulog.add outside of the 
getIndexWriter/release block was correct.
{quote}

Right - the expected use is to be careful and quickly get and release the 
writer so that you don't accidentally try and getwriter or newwriter in 
between. This is why I thought Erik's first fix attempt sounded right. But then 
I guess he started hitting the deadlock you are still getting and figured it 
was not correct. Seems like it is correct, but we also have to address this 
other issue.

> Possible deadlock when closing refcounted index writers.
> --------------------------------------------------------
>
>                 Key: SOLR-7836
>                 URL: https://issues.apache.org/jira/browse/SOLR-7836
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>             Fix For: Trunk, 5.4
>
>         Attachments: SOLR-7836-synch.patch, SOLR-7836.patch, SOLR-7836.patch, 
> SOLR-7836.patch, deadlock_3.res.zip, deadlock_5_pass_iw.res.zip, deadlock_test
>
>
> Preliminary patch for what looks like a possible race condition between 
> writerFree and pauseWriter in DefaultSorlCoreState.
> Looking for comments and/or why I'm completely missing the boat.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to