[
https://issues.apache.org/jira/browse/SOLR-7876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721355#comment-14721355
]
Erick Erickson commented on SOLR-7876:
--------------------------------------
The test that it cured was this sequence:
> send a query that times out (no fq clauses)
> send the same query that does not time out (still no fq clauses)
***>test the second response to see if partialResults==true
It's the *** part the suddenly succeeded after this patch. Prior to this patch
partialResults was true, now it's just not returned in the second response at
all, which makes sense on the surface if your patch bails out from that wrapper
earlier. This test was returning the correct number of docs before, it was just
that the partialResults was incorrectly returned.
The tests that go against the filterCache are _still_ failing though, so it's
not like this patch magically fixed any of the caching problems.
So I'd guess not returning the partialResults flag makes more sense in terms of
this patch?
Haven't updated the test patch yet, just tried it locally.
> Support disabling ExitableDirectory wrapper when not needed
> -----------------------------------------------------------
>
> Key: SOLR-7876
> URL: https://issues.apache.org/jira/browse/SOLR-7876
> Project: Solr
> Issue Type: Bug
> Affects Versions: 5.0, 5.1, 5.2, 5.2.1
> Reporter: Tomás Fernández Löbbe
> Fix For: Trunk, 5.4
>
> Attachments: SOLR-7876.patch
>
>
> ExitableDirectoryReader can cause some overhead in Solr for some use cases,
> even when not really used. There should be a way of not using it when not
> needed.
> See http://search-lucene.com/m/l6pAi1HLrodLhNUd
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
