[
https://issues.apache.org/jira/browse/SOLR-7876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721556#comment-14721556
]
Erick Erickson commented on SOLR-7876:
--------------------------------------
OK, on a second look it was a bad test.
copy/pasted the original code for the first call with timeAllowed=1 that looked
at partialResults but didn't test for null. Just saw the error and didn't read
it carefully.
assertFalse("Should NOT have partial results", (Boolean)
(header.get("partialResults"));
When timeAllowed=1000, get("partialResults") returns null.....
So this patch has no effect whatsoever on the new tests I wrote. I removed the
linked-to.
> Support disabling ExitableDirectory wrapper when not needed
> -----------------------------------------------------------
>
> Key: SOLR-7876
> URL: https://issues.apache.org/jira/browse/SOLR-7876
> Project: Solr
> Issue Type: Bug
> Affects Versions: 5.0, 5.1, 5.2, 5.2.1
> Reporter: Tomás Fernández Löbbe
> Fix For: Trunk, 5.4
>
> Attachments: SOLR-7876.patch
>
>
> ExitableDirectoryReader can cause some overhead in Solr for some use cases,
> even when not really used. There should be a way of not using it when not
> needed.
> See http://search-lucene.com/m/l6pAi1HLrodLhNUd
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
