[ 
https://issues.apache.org/jira/browse/LUCENE-6845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964027#comment-14964027
 ] 

David Smiley commented on LUCENE-6845:
--------------------------------------

Sounds great.  But as I started to look at the patch; it became clear that it's 
hard to review with the renames to have the Scorer Suffix.  Perhaps, 
temporarily, you could not do that to make it more reviewable?

I'm anticipating I'm going to see stuff that suggests this should wait for 6.0. 
 What do you think?

> Merge Spans and SpanScorer
> --------------------------
>
>                 Key: LUCENE-6845
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6845
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>             Fix For: Trunk, 5.4
>
>         Attachments: LUCENE-6845.patch
>
>
> SpanScorer and Spans currently share the burden of scoring span queries, with 
> SpanScorer delegating to Spans for most operations.  Spans is essentially a 
> Scorer, just with the ability to iterate through positions as well, and no 
> SimScorer to use for scoring.  This seems overly complicated.  We should 
> merge the two classes into one.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to