[
https://issues.apache.org/jira/browse/SOLR-8147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14972855#comment-14972855
]
Scott Stults commented on SOLR-8147:
------------------------------------
You're right: SolrException isn't an IOException, and the latter is probably
more appropriate given the class hierarchy.
As far as moving the hasDocValues() check though, I'm conflicted. On the one
hand it would be better to catch the problem as early as possible. On the
other, locating the check closer to where it's needed reduces code complexity.
Which do you think is more valuable in this case?
> FieldFacetAccumulator constructor throws too many exceptions
> ------------------------------------------------------------
>
> Key: SOLR-8147
> URL: https://issues.apache.org/jira/browse/SOLR-8147
> Project: Solr
> Issue Type: Improvement
> Components: SearchComponents - other
> Affects Versions: 5.0, Trunk
> Reporter: Scott Stults
> Priority: Trivial
> Fix For: 5.0, Trunk
>
> Attachments: SOLR-8147.patch
>
>
> The constructor and static create method in FieldFacetAccumulator don't need
> to throw IOException, just SolrException.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
