[ 
https://issues.apache.org/jira/browse/SOLR-8147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976732#comment-14976732
 ] 

Christine Poerschke commented on SOLR-8147:
-------------------------------------------

Okay, so if we're looking at moving not only {{hasDocValues()}} but also other 
error checking in a similar manner out of the accumulator class(es) - how about 
we keep this JIRA ticket at its original scope i.e. reducing the number of 
exceptions {{FieldFacetAccumulator}} throws (perhaps leaving the IOException 
and removing the SolrException as per our comments above) and for the check 
moving efforts we'd create a separate JIRA ticket. How does that sound?

> FieldFacetAccumulator constructor throws too many exceptions
> ------------------------------------------------------------
>
>                 Key: SOLR-8147
>                 URL: https://issues.apache.org/jira/browse/SOLR-8147
>             Project: Solr
>          Issue Type: Improvement
>          Components: SearchComponents - other
>    Affects Versions: 5.0, Trunk
>            Reporter: Scott Stults
>            Priority: Trivial
>             Fix For: 5.0, Trunk
>
>         Attachments: SOLR-8147.patch
>
>
> The constructor and static create method in FieldFacetAccumulator don't need 
> to throw IOException, just SolrException. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to