[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15002394#comment-15002394
]
Erik Hatcher commented on SOLR-3191:
------------------------------------
[~demiankatz] thanks for the review; it got me looking at this patch deeper
myself. To address your questions, as I look into it myself:
1) getFieldName is used by some unrelated (LegacyFacet) code only, so seems to
be untouched/unused here. Good eye, but no worries here.
2) Another good eye (how are you testing coverage?) - collectingLiteral is only
used when there are single or double quotes being parsed in an fl, which none
of the tests do. A different ParserStage is used for regular field names.
3) I don't think we need to test the .toString of the Set returned, but point
taken about testing getReturnFieldNames() contents.
Still reviewing...
> field exclusion from fl
> -----------------------
>
> Key: SOLR-3191
> URL: https://issues.apache.org/jira/browse/SOLR-3191
> Project: Solr
> Issue Type: Improvement
> Reporter: Luca Cavanna
> Priority: Minor
> Attachments: SOLR-3191.patch, SOLR-3191.patch, SOLR-3191.patch,
> SOLR-3191.patch
>
>
> I think it would be useful to add a way to exclude field from the Solr
> response. If I have for example 100 stored fields and I want to return all of
> them but one, it would be handy to list just the field I want to exclude
> instead of the 99 fields for inclusion through fl.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
