[ 
https://issues.apache.org/jira/browse/SOLR-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010441#comment-15010441
 ] 

Shawn Heisey commented on SOLR-8306:
------------------------------------

Thanks for helping out!  I don't know anything about ExpandComponent, so I'm 
not qualified to review your patch.  The idea sounds generally useful, though.

Patches against trunk are preferred.  This is where primary development occurs. 
 Most of the changes that are applied to trunk are also backported to the 
stable branch, which is currently branch_5x.

We can frequently work with patches against the stable branch as well, because 
those patches will usually apply to trunk without a lot of manual work.

The tag for the latest release, which is what you used, can work very well, but 
sometimes it doesn't.  Tags are static, so trunk and the stable branch can 
sometimes diverge significantly from the last release tag.  When there is a lot 
of divergence, it can be very difficult to apply the patch to the working 
branches.


> Enhance ExpandComponent to allow expand.hits=0
> ----------------------------------------------
>
>                 Key: SOLR-8306
>                 URL: https://issues.apache.org/jira/browse/SOLR-8306
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 5.3.1
>            Reporter: Marshall Sanders
>            Priority: Minor
>              Labels: expand
>             Fix For: 5.3.1
>
>         Attachments: SOLR-8306.patch
>
>
> This enhancement allows the ExpandComponent to allow expand.hits=0 for those 
> who don't want an expanded document returned and only want the numFound from 
> the expand section.
> This is useful for "See 54 more like this" use cases, but without the 
> performance hit of gathering an entire expanded document.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to