[
https://issues.apache.org/jira/browse/SOLR-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15023246#comment-15023246
]
Shawn Heisey commented on SOLR-8333:
------------------------------------
Since ConcurrentLFUCache was my creation (mostly based on ConcurrentLRUCache),
I've been thinking about how to fix it. Making CacheEntry public is the simple
fix, but since the class should only be used internally and never by users, I
wonder if this is better:
* Move it to org.apache.solr.search
* Remove the "public" modifier on the class so it's the default package-private
* Change the problem inner class (CacheEntry) and much of what is currently
public to protected.
> fix public methods that take/return private/package-private arguments/results
> -----------------------------------------------------------------------------
>
> Key: SOLR-8333
> URL: https://issues.apache.org/jira/browse/SOLR-8333
> Project: Solr
> Issue Type: Bug
> Reporter: Hoss Man
>
> background info:
> http://mail-archives.apache.org/mod_mbox/lucene-dev/201511.mbox/%3Calpine.DEB.2.11.1511231128450.24330@tray%3E
> A commit that added a package to solrj which already existed in solr-core
> caused the javadoc link checker to uncover at least 4 instances of private or
> package-private classes being neccessary to use public APIs.
> we should fix these instances and any other instances of APIs with similar
> problems that we can find.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
