[ 
https://issues.apache.org/jira/browse/SOLR-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15023520#comment-15023520
 ] 

Erik Hatcher commented on SOLR-8333:
------------------------------------

I've confirmed that "ant documentation-lint" is happy when:

{code}
A  +    solr/solrj/src/java/org/apache/solr/common/EmptyEntityResolver.java
D       solr/solrj/src/java/org/apache/solr/util/EmptyEntityResolver.java
{code}

This class is final, but if it helps we could copy/paste this same class to 
core's org.apache.solr.util so that any external references to it don't break 
(but I doubt this is externally used and if so, that's an ok break with me).

> fix public methods that take/return private/package-private arguments/results
> -----------------------------------------------------------------------------
>
>                 Key: SOLR-8333
>                 URL: https://issues.apache.org/jira/browse/SOLR-8333
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Hoss Man
>         Attachments: SOLR-8333-ConcurrentLFUCache-protected.patch, 
> SOLR-8333.patch
>
>
> background info: 
> http://mail-archives.apache.org/mod_mbox/lucene-dev/201511.mbox/%3Calpine.DEB.2.11.1511231128450.24330@tray%3E
> A commit that added a package to solrj which already existed in solr-core 
> caused the javadoc link checker to uncover at least 4 instances of private or 
> package-private classes being neccessary to use public APIs.
> we should fix these instances and any other instances of APIs with similar 
> problems that we can find.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to