[
https://issues.apache.org/jira/browse/SOLR-8359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036334#comment-15036334
]
Jason Gerlowski commented on SOLR-8359:
---------------------------------------
Sure, good catch Mike, I didn't even think of this.
I did a quick grep around for other instances of this. So add
{{CdcrTransactionLog}} to the list. Hopefully we're not missing any other
classes here.
Should anything go in CHANGES.txt for this JIRA? I lean towards "no", since
this is just fallout from another change that's already mentioned in
CHANGES.txt. But I'm not very familiar with when/how/why things get added to
that file, so maybe I've got the wrong approach.
I'm running tests on a patch now, will upload it shortly if all goes well.
> Restrict child classes from using parent logger's state
> -------------------------------------------------------
>
> Key: SOLR-8359
> URL: https://issues.apache.org/jira/browse/SOLR-8359
> Project: Solr
> Issue Type: Sub-task
> Reporter: Mike Drob
> Fix For: Trunk
>
>
> In SOLR-8330 we split up a lot of loggers. However, there are a few classes
> that still use their parent's logging state and configuration indirectly.
> {{HdfsUpdateLog}} and {{HdfsTransactionLog}} both use their parent class
> cached read of {{boolean debug = log.isDebugEnabled()}}, when they should
> check their own loggers instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
