[
https://issues.apache.org/jira/browse/SOLR-8359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036483#comment-15036483
]
Mike Drob commented on SOLR-8359:
---------------------------------
Not sure it makes sense to always make these cached boolean {{private static
final}}. {{UpdateLog.preSoftCommit}} would refresh the values, I think
{{HdfsUpdateLog}} now misses out on that, haven't confirmed though. Logging
levels can change dynamically via the Solr UI or through file watchdogs,
depending on the impl used.
Also I don't see changes to {{CdcrTransactionLog}} like you mentioned - was
that a false positive in your previous comment?
> Restrict child classes from using parent logger's state
> -------------------------------------------------------
>
> Key: SOLR-8359
> URL: https://issues.apache.org/jira/browse/SOLR-8359
> Project: Solr
> Issue Type: Sub-task
> Reporter: Mike Drob
> Fix For: Trunk
>
> Attachments: SOLR-8359.patch
>
>
> In SOLR-8330 we split up a lot of loggers. However, there are a few classes
> that still use their parent's logging state and configuration indirectly.
> {{HdfsUpdateLog}} and {{HdfsTransactionLog}} both use their parent class
> cached read of {{boolean debug = log.isDebugEnabled()}}, when they should
> check their own loggers instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
