[ 
https://issues.apache.org/jira/browse/LUCENE-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036726#comment-15036726
 ] 

Michael McCandless commented on LUCENE-6908:
--------------------------------------------

Thanks [~nknize]!  Lots of geo math that I don't understand :)

It hit a failure after some beasting:

{noformat}
   [junit4] Started J0 PID(28075@localhost).
   [junit4] Suite: org.apache.lucene.util.TestGeoUtils
   [junit4]   1> doc=2304 matched but should not
   [junit4]   1>   lon=-52.68950667232275 lat=-89.24937685020268 
distanceMeters=267809.96722662856 vs radiusMeters=263432.23741533695
   [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=TestGeoUtils 
-Dtests.method=testGeoRelations -Dtests.seed=3B46325723FB86A9 
-Dtests.multiplier=5 -Dtests.slow=true 
-Dtests.linedocsfile=/lucenedata/hudson.enwiki.random.lines.txt.fixed 
-Dtests.locale=vi_VN -Dtests.timezone=America/Halifax -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
   [junit4] FAILURE 2.61s | TestGeoUtils.testGeoRelations <<<
   [junit4]    > Throwable #1: java.lang.AssertionError: 1 incorrect hits (see 
above)
   [junit4]    >        at 
__randomizedtesting.SeedInfo.seed([3B46325723FB86A9:F96526E2570CF017]:0)
   [junit4]    >        at 
org.apache.lucene.util.TestGeoUtils.testGeoRelations(TestGeoUtils.java:533)
   [junit4]    >        at java.lang.Thread.run(Thread.java:745)
   [junit4]   2> NOTE: test params are: 
codec=HighCompressionCompressingStoredFields(storedFieldsFormat=CompressingStoredFieldsFormat(compressionMode=HIGH_COMPRESSION,
 chunkSize=9, maxDocsPerChunk=323, blockSize=5), 
termVectorsFormat=CompressingTermVectorsFormat(compressionMode=HIGH_COMPRESSION,
 chunkSize=9, blockSize=5)), 
sim=RandomSimilarityProvider(queryNorm=true,coord=yes): {}, locale=vi_VN, 
timezone=America/Halifax
   [junit4]   2> NOTE: Linux 3.13.0-61-generic amd64/Oracle Corporation 
1.8.0_60 (64-bit)/cpus=8,threads=1,free=396588944,total=504889344
   [junit4]   2> NOTE: All tests run in this JVM: [TestGeoUtils]
   [junit4] Completed [1/1] in 2.77s, 1 test, 1 failure <<< FAILURES!
{noformat}

Also, this comment seems stale now?  (We seem to be using this method?):

{noformat}
// NOTE: not used for 2d at the moment. used for 3d w/ altitude (we can keep or 
add back)
{noformat}


> TestGeoUtils.testGeoRelations is buggy with irregular rectangles
> ----------------------------------------------------------------
>
>                 Key: LUCENE-6908
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6908
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Nicholas Knize
>         Attachments: LUCENE-6908.patch, LUCENE-6908.patch, LUCENE-6908.patch
>
>
> The {{.testGeoRelations}} method doesn't exactly test the behavior of 
> GeoPoint*Query as its using the BKD split technique (instead of quad cell 
> division) to divide the space on each pass. For "large" distance queries this 
> can create a lot of irregular rectangles producing large radial distortion 
> error when using the cartesian approximation methods provided by 
> {{GeoUtils}}. This issue improves the accuracy of GeoUtils cartesian 
> approximation methods on irregular rectangles without having to cut over to 
> an expensive oblate geometry approach.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to