[ 
https://issues.apache.org/jira/browse/SOLR-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15046221#comment-15046221
 ] 

Jason Gerlowski commented on SOLR-8266:
---------------------------------------

No problem; hopefully you're still as thankful after giving it a review :-p

I did write it against trunk, though I can put it on top of another branch if 
you'd prefer.

I was aware of the patch naming convention.  I broke it in an effort to call 
out that this patch contains a commented out test, and (probably? maybe?) 
shouldn't be committed as-is.  If that break from convention isn't worthwhile 
though, I'll stop doing that sort of thing.  Still learning the ropes here a 
bit.

As for the questions/change-suggestions in my earlier comment, I'll throw 
together JIRAs for those and toss up a starter patch on them.

> Remove Java Serialization from the Streaming API
> ------------------------------------------------
>
>                 Key: SOLR-8266
>                 URL: https://issues.apache.org/jira/browse/SOLR-8266
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Joel Bernstein
>         Attachments: SOLR-8266-comment-out-testParallelEOF.patch, 
> SOLR-8266.patch
>
>
> This is being done mainly for security reasons but it's also architecturally 
> the right thing to do.
> Going forward only Streaming Expressions will be used to serialize Streaming 
> API Objects. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to