[ 
https://issues.apache.org/jira/browse/SOLR-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15046241#comment-15046241
 ] 

Mike Drob commented on SOLR-8266:
---------------------------------

bq. I was aware of the patch naming convention. I broke it in an effort to call 
out that this patch contains a commented out test, and (probably? maybe?) 
shouldn't be committed as-is. If that break from convention isn't worthwhile 
though, I'll stop doing that sort of thing. Still learning the ropes here a bit.

I've seen folks put a {{//nocommit}} tag to intentionally fail the validation 
check in cases like these.

> Remove Java Serialization from the Streaming API
> ------------------------------------------------
>
>                 Key: SOLR-8266
>                 URL: https://issues.apache.org/jira/browse/SOLR-8266
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Joel Bernstein
>         Attachments: SOLR-8266-comment-out-testParallelEOF.patch, 
> SOLR-8266.patch
>
>
> This is being done mainly for security reasons but it's also architecturally 
> the right thing to do.
> Going forward only Streaming Expressions will be used to serialize Streaming 
> API Objects. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to