[ 
https://issues.apache.org/jira/browse/SOLR-8416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060419#comment-15060419
 ] 

Mark Miller commented on SOLR-8416:
-----------------------------------

Thanks for the patch, a couple comments:

* Usually it's better to use SolrException over RuntimeException
* Where you catch the interrupted exception, you should restore the interrupted 
status.
* The failure exception should probably give detail on which replicas were not 
found to be live and ACTIVE.
* Should not use hard coded 'active' but the relevant constants.
* Should probably check if the replicas node is listed under live nodes as well 
as if it's active?

> Solr collection creation API should return after all cores are alive 
> ---------------------------------------------------------------------
>
>                 Key: SOLR-8416
>                 URL: https://issues.apache.org/jira/browse/SOLR-8416
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>            Reporter: Michael Sun
>         Attachments: SOLR-8416.patch
>
>
> Currently the collection creation API returns once all cores are created. In 
> large cluster the cores may not be alive for some period of time after cores 
> are created. For any thing requested during that period, Solr appears 
> unstable and can return failure. Therefore it's better  the collection 
> creation API waits for all cores to become alive and returns after that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to