[
https://issues.apache.org/jira/browse/SOLR-8452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068638#comment-15068638
]
Yonik Seeley commented on SOLR-8452:
------------------------------------
It's not a big deal, but I'm not sure we should be replacing literals with
references in tests, as it actually reduces what is actually tested. If
someone accidentally (or on purpose) change the constant, all of the tests will
magically pass.
> replace "partialResults" occurrences with
> SolrQueryResponse.RESPONSE_HEADER_PARTIAL_RESULTS_KEY
> -----------------------------------------------------------------------------------------------
>
> Key: SOLR-8452
> URL: https://issues.apache.org/jira/browse/SOLR-8452
> Project: Solr
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Attachments: SOLR-8452.patch
>
>
> proposed patch against trunk to follow (The
> {{TestSolrQueryResponse.testResponseHeaderPartialResults()}} test within the
> patch is to ensure that inadvertent, non-backwards-compatible changes to
> {{SolrQueryResponse.RESPONSE_HEADER_PARTIAL_RESULTS_KEY}} result in test
> failure.)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
