[ 
https://issues.apache.org/jira/browse/SOLR-8452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068645#comment-15068645
 ] 

Christine Poerschke commented on SOLR-8452:
-------------------------------------------

The (added by this revision) 
{{TestSolrQueryResponse.testResponseHeaderPartialResults()}} test would also 
have to accidentally (or on purpose) be changed to match the changed constant 
value, but yes, that would be only one specific failed test instead of 
potentially several general failing tests.

> replace "partialResults" occurrences with 
> SolrQueryResponse.RESPONSE_HEADER_PARTIAL_RESULTS_KEY
> -----------------------------------------------------------------------------------------------
>
>                 Key: SOLR-8452
>                 URL: https://issues.apache.org/jira/browse/SOLR-8452
>             Project: Solr
>          Issue Type: Task
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>         Attachments: SOLR-8452.patch
>
>
> proposed patch against trunk to follow (The 
> {{TestSolrQueryResponse.testResponseHeaderPartialResults()}} test within the 
> patch is to ensure that inadvertent, non-backwards-compatible changes to 
> {{SolrQueryResponse.RESPONSE_HEADER_PARTIAL_RESULTS_KEY}} result in test 
> failure.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to