[
https://issues.apache.org/jira/browse/LUCENE-6958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15081361#comment-15081361
]
Uwe Schindler commented on LUCENE-6958:
---------------------------------------
bq. Yes, would remove some code duplication, but that's a one-liner only. Will
think about it.
I don't think this is needed. It is only one method call and the boolean flag
change. If we have further refactoring this would make sense, but now it adds 3
methods for nothing (and makes it unreadable).
> Improve CustomAnalyzer to also allow to specify factory directly (for
> compile-time safety)
> ------------------------------------------------------------------------------------------
>
> Key: LUCENE-6958
> URL: https://issues.apache.org/jira/browse/LUCENE-6958
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
> Affects Versions: 5.4
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 5.5
>
> Attachments: LUCENE-6958.patch
>
>
> Currently CustomAnalyzer only allows to specify the SPI names of factories.
> As the fluent builder pattern is mostly used inside Java code, it is better
> for type safety to optionally also specify the factory class directly (using
> compile-time safe patterns like
> {{.withTokenizer(WhitespaceTokenizerFactory.class)}}). With the string names,
> you get the error only at runtime. Of course this does not help with wrong,
> spelled parameter names, but it also has the side effect that you can click
> on the class name in your code to get javadocs with the parameter names.
> This issue will add this functionality and update the docs/example.
> Thanks to [~shaie] for suggesting this!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
