[
https://issues.apache.org/jira/browse/LUCENE-6958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082730#comment-15082730
]
ASF subversion and git services commented on LUCENE-6958:
---------------------------------------------------------
Commit 1723027 from [~thetaphi] in branch 'dev/trunk'
[ https://svn.apache.org/r1723027 ]
LUCENE-6958: Improve CustomAnalyzer to take class references to factories as
alternative to their SPI name. This enables compile-time safety when defining
analyzer's components
> Improve CustomAnalyzer to also allow to specify factory directly (for
> compile-time safety)
> ------------------------------------------------------------------------------------------
>
> Key: LUCENE-6958
> URL: https://issues.apache.org/jira/browse/LUCENE-6958
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
> Affects Versions: 5.4
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 5.5
>
> Attachments: LUCENE-6958.patch, LUCENE-6958.patch
>
>
> Currently CustomAnalyzer only allows to specify the SPI names of factories.
> As the fluent builder pattern is mostly used inside Java code, it is better
> for type safety to optionally also specify the factory class directly (using
> compile-time safe patterns like
> {{.withTokenizer(WhitespaceTokenizerFactory.class)}}). With the string names,
> you get the error only at runtime. Of course this does not help with wrong,
> spelled parameter names, but it also has the side effect that you can click
> on the class name in your code to get javadocs with the parameter names.
> This issue will add this functionality and update the docs/example.
> Thanks to [~shaie] for suggesting this!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
