[
https://issues.apache.org/jira/browse/SOLR-8490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15085616#comment-15085616
]
Shai Erera commented on SOLR-8490:
----------------------------------
[~cpoerschke] on SOLR-8475 I replied to you that I prefer that we didn't add
all this back-compat deprecated classes, and we seem to have reached consensus
on the list about these classes. Is it really necessary to do all those
changes? My patch on SOLR-8475 already factors out QueryCommand, only without
all the deprecations.
> factor out a QueryCommand (super) class from SolrIndexSearcher.QueryCommand
> ---------------------------------------------------------------------------
>
> Key: SOLR-8490
> URL: https://issues.apache.org/jira/browse/SOLR-8490
> Project: Solr
> Issue Type: Sub-task
> Components: search
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Fix For: 5.5, Trunk
>
> Attachments: SOLR-8490-part0.patch, SOLR-8490-part1.patch,
> SOLR-8490-part2.patch
>
>
> part 0 (for trunk and branch_5x) - preparation:
> * two minor changes in {{QueryComponent.java}} and
> {{SolrIndexSearcher.java}} to simplify the subsequent actual changes
> part 1 (for trunk and branch_5x) - factor out a {{QueryCommand}} (super)
> class from {{SolrIndexSearcher.QueryCommand}}:
> * for back-compat reasons {{SolrIndexSearcher.QueryCommand}} inherits from
> the factored out class
> * for private variables and methods use {{QueryCommand}} instead of
> {{SolrIndexSearcher.QueryCommand}}
> * public methods and constructors taking {{SolrIndexSearcher.QueryCommand}}
> args marked @Deprecated and equivalents with {{QueryCommand}} arg created
> part 2 (for trunk only) - remove deprecated
> {{SolrIndexSearcher.QueryCommand}} class:
> * affected/changed public or protected methods:
> ** {{ResponseBuilder.getQueryCommand()}}
> ** {{SolrIndexSearcher.search(QueryResult qr, QueryCommand cmd)}}
> ** {{SolrIndexSearcher.sortDocSet(QueryResult qr, QueryCommand cmd)}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
