[
https://issues.apache.org/jira/browse/SOLR-8490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15085647#comment-15085647
]
Christine Poerschke commented on SOLR-8490:
-------------------------------------------
[~shaie] - apologies, i should have clarified my intentions here re: the patch
attachments which were to do the independent 'part 0' only and the rest only if
and when there is consensus that they are needed and it's clear from SOLR-8475
and the list that there is no need and so the 'part 1 & 2' basically then just
illustrate that the effort:benefit ratio of back-compat classes here is not
there and so i will withdraw this sub-task here.
With respect to SOLR-8482 which adds an extra accessor to {{QueryCommand}} -
would you prefer i go ahead with that ahead of SOLR-8475 or wait on SOLR-8475?
Sorry for the confusion.
> factor out a QueryCommand (super) class from SolrIndexSearcher.QueryCommand
> ---------------------------------------------------------------------------
>
> Key: SOLR-8490
> URL: https://issues.apache.org/jira/browse/SOLR-8490
> Project: Solr
> Issue Type: Sub-task
> Components: search
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Fix For: 5.5, Trunk
>
> Attachments: SOLR-8490-part0.patch, SOLR-8490-part1.patch,
> SOLR-8490-part2.patch
>
>
> part 0 (for trunk and branch_5x) - preparation:
> * two minor changes in {{QueryComponent.java}} and
> {{SolrIndexSearcher.java}} to simplify the subsequent actual changes
> part 1 (for trunk and branch_5x) - factor out a {{QueryCommand}} (super)
> class from {{SolrIndexSearcher.QueryCommand}}:
> * for back-compat reasons {{SolrIndexSearcher.QueryCommand}} inherits from
> the factored out class
> * for private variables and methods use {{QueryCommand}} instead of
> {{SolrIndexSearcher.QueryCommand}}
> * public methods and constructors taking {{SolrIndexSearcher.QueryCommand}}
> args marked @Deprecated and equivalents with {{QueryCommand}} arg created
> part 2 (for trunk only) - remove deprecated
> {{SolrIndexSearcher.QueryCommand}} class:
> * affected/changed public or protected methods:
> ** {{ResponseBuilder.getQueryCommand()}}
> ** {{SolrIndexSearcher.search(QueryResult qr, QueryCommand cmd)}}
> ** {{SolrIndexSearcher.sortDocSet(QueryResult qr, QueryCommand cmd)}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
