All discussion in the Github PR is captured in JIRA if the two are linked, see https://issues.apache.org/jira/browse/SOLR-8166 as an example If they are not linked, comments go to the dev list. So we can keep it as today - allow people to choose freely to use patches and/or PRs. NOTE: We should always create JIRA for PR’s that we want to fix.
-- Jan Høydahl, search solution architect Cominvent AS - www.cominvent.com > 11. jan. 2016 kl. 09.13 skrev Dawid Weiss <[email protected]>: > > Remember github is an external service, if it vanishes so would all > comments and discussion. I'd stick with Jira, at least for the time > being (until people get more familiar with git). Not everything at > once. > > Dawid > > On Mon, Jan 11, 2016 at 9:11 AM, Shai Erera <[email protected]> wrote: >> I think it will be nice if we integrate a code review tool into our >> workflow, such as Gerrit maybe (even Github pull requests are good), instead >> of the patch workflow with JIRA. >> >> But I agree we don't have to change that, not at start at least. The move to >> git will allow those who want it, to use the code review tool on Github (via >> pull requests). >> >> Shai >> >> On Mon, Jan 11, 2016 at 5:27 AM Mark Miller <[email protected]> wrote: >>> >>> I don't think there is a current plan to change how we do business. Just a >>> change in where the master copy is hosted. >>> >>> We already have JIRA, dev, commit procedures, and integration with GitHub >>> pull requests. All that will stay the same. No need to overthink it. >>> >>> - Mark >>> >>> On Sun, Jan 10, 2016 at 4:18 PM Jack Krupansky <[email protected]> >>> wrote: >>>> >>>> Will anybody be able to create a pull request and then only committers >>>> perform the merge operation? (I presume so, but... just for clarity, >>>> especially for those not git-savvy yet.) >>>> >>>> Would patches still be added to Jira requests, or simply a link to a pull >>>> request? (Again, I presume the latter, but the details of "submitting a >>>> patch" should be clearly documented.) >>>> >>>> Then there is the matter of code review and whether to encourage comments >>>> in Jira. Comments can be made on pull requests, but should some external >>>> tool like reviewable.io be encouraged? >>>> >>>> -- Jack Krupansky >>>> >>>> On Sat, Jan 9, 2016 at 4:54 PM, Mark Miller <[email protected]> >>>> wrote: >>>>> >>>>> We have done almost all of the work necessary for a move and I have >>>>> filed an issue with INFRA. >>>>> >>>>> LUCENE-6937: Migrate Lucene project from SVN to Git. >>>>> https://issues.apache.org/jira/browse/LUCENE-6937 >>>>> >>>>> INFRA-11056: Migrate Lucene project from SVN to Git. >>>>> https://issues.apache.org/jira/browse/INFRA-11056 >>>>> >>>>> Everyone knows about rebase and linear history right ;) >>>>> >>>>> - Mark >>>>> -- >>>>> - Mark >>>>> about.me/markrmiller >>>> >>>> >>> -- >>> - Mark >>> about.me/markrmiller > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
