[
https://issues.apache.org/jira/browse/SOLR-2798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15096910#comment-15096910
]
Demian Katz commented on SOLR-2798:
-----------------------------------
How does this look?
https://github.com/apache/lucene-solr/compare/trunk...demiankatz:solr-2798-fix?expand=1
Some notes/comments:
1.) I'm pretty confident that my refactoring of parseLocalParams() is sound, as
I added some tests and confirmed that they passed before and after my work.
2.) Speaking of those new tests, I'm not sure if they are in the most
appropriate place, or if we even want to keep the map-oriented ones in the long
term since those methods should be deprecated.
3.) Speaking of deprecated methods, I didn't do anything to flag them -- not
sure what the convention is in this project.
4.) As of this writing, I'm still running the full test suite to see if my
other refactoring (to use the new parseLocalParams instead of the old) is okay.
Not sure if there are more targeted tests that need to be written to truly
confirm this. In any case, most of my changes seemed pretty straightforward, so
I went ahead and committed them to my branch since I expect the tests will run
for a couple of hours and I wanted to get this done before going home for the
day. If I see any breaks, I'll fix them tomorrow.
I'll be interested to hear your thoughts... and thanks for your guidance, which
was absolutely invaluable in getting this far!
> Local Param parsing does not support multivalued params
> -------------------------------------------------------
>
> Key: SOLR-2798
> URL: https://issues.apache.org/jira/browse/SOLR-2798
> Project: Solr
> Issue Type: Bug
> Reporter: Hoss Man
> Assignee: Anshum Gupta
>
> As noted by Demian on the solr-user mailing list, Local Param parsing seems
> to use a "last one wins" approach when parsing multivalued params.
> In this example, the value of "111" is completely ignored:
> {code}
> http://localhost:8983/solr/select?debug=query&q={!dismax%20bq=111%20bq=222}foo
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
