[
https://issues.apache.org/jira/browse/LUCENE-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005169#comment-13005169
]
Michael McCandless commented on LUCENE-2958:
--------------------------------------------
It's great to make line file docs more extensible! Maybe, we should
put the field names as a header line? Then the source can get the
field names from there?
feilds is mis-spelled
The cutover to splitting by regex (vs prior split-by-char) makes me
nervous. Have you tested perf hit? Or, can we go back to just using
a char sep? We also make a String[] when we didn't before. If we
really want to stick w/ regex then we should at least pre-compile to
a Pattern then use the split method on that?
> WriteLineDocTask improvements
> -----------------------------
>
> Key: LUCENE-2958
> URL: https://issues.apache.org/jira/browse/LUCENE-2958
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/benchmark
> Reporter: Doron Cohen
> Assignee: Doron Cohen
> Priority: Minor
> Fix For: 3.2, 4.0
>
> Attachments: LUCENE-2958.patch, LUCENE-2958.patch
>
>
> Make WriteLineDocTask and LineDocSource more flexible/extendable:
> * allow to emit lines also for empty docs (keep current behavior as default)
> * allow more/less/other fields
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
