[ 
https://issues.apache.org/jira/browse/LUCENE-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005607#comment-13005607
 ] 

Michael McCandless commented on LUCENE-2958:
--------------------------------------------

bq. If we do the header idea, then we'll need to move to a more generic 
DocData. So instead of doing docData.title = title, you'll need to do 
docData.set("title", title), which under the hood will store that pair in a Map 
or Properties. Similarly for 'getter'. That also has some implications on perf.

Hmm, true.

Really, it would be better if LineDocSource could directly set Field values.  
Then, up front on parsing the header it could make a Field[], and then when 
parsing the line it'd just set these Field values.  

But that's a much larger change... so I think until then we should just pass 
the full String line to eg a processLine method?  And the default optimized one 
breaks it into the fixed name/date/body fields.

> WriteLineDocTask improvements
> -----------------------------
>
>                 Key: LUCENE-2958
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2958
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/benchmark
>            Reporter: Doron Cohen
>            Assignee: Doron Cohen
>            Priority: Minor
>             Fix For: 3.2, 4.0
>
>         Attachments: LUCENE-2958.patch, LUCENE-2958.patch
>
>
> Make WriteLineDocTask and LineDocSource more flexible/extendable:
> * allow to emit lines also for empty docs (keep current behavior as default)
> * allow more/less/other fields

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to