[
https://issues.apache.org/jira/browse/LUCENE-7010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130798#comment-15130798
]
Shai Erera commented on LUCENE-7010:
------------------------------------
[~thetaphi] do you still have concerns about it? I agree it looks silly that
NoMP overrides methods just to call super(). So we have few options:
* I keep the overrides, but don't do anything in the setters and return 0 in
the getters.
* We drop these overrides and either tweak the test, or remove it.
If we need to change anything, I'd prefer to do the former. What do you think?
> Create MergePolicyWrapper
> -------------------------
>
> Key: LUCENE-7010
> URL: https://issues.apache.org/jira/browse/LUCENE-7010
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
> Reporter: Shai Erera
> Assignee: Shai Erera
> Attachments: LUCENE-7010.patch
>
>
> We currently have two MergePolicy implementations that are wrappers around
> another MP: {{SortingMergePolicy}} and {{UpgradeIndexMergePolicy}}. A
> {{MergePolicyWrapper}} will simplify building additional such wrapping MPs by
> delegating all method calls to the wrapped instance, and allowing
> implementations to override only what they need.
> Also, this issue removes the {{final}} modifier from MP public methods so
> that they can be delegated properly. See LUCENE-7008 for a test failure that
> uncovered this issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
