[
https://issues.apache.org/jira/browse/LUCENE-7015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15158154#comment-15158154
]
Steve Rowe commented on LUCENE-7015:
------------------------------------
Thanks Nick, LGTM.
A couple nits:
* Your patch includes import/whitespace-trimming-only changes 4 Solr .java
files - those changes should be made elsewhere, not on this issue.
* In {{spatial-extras/build.xml}}, the "spatialextrasjar" path id is a
misnomer, should be spatial4j-jar or something like that (in spatial module
it's currently named "spatialjar")
* In {{spatial-extras/build.xml}}: spatial4j-tests.jar should go to test-lib/
instead of lib/ (note that this same issue was present in the spatial module,
I'm fine with leaving this as-is for this JIRA).
> Refactor spatial module to spatial-extras
> -----------------------------------------
>
> Key: LUCENE-7015
> URL: https://issues.apache.org/jira/browse/LUCENE-7015
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial
> Reporter: Nicholas Knize
> Assignee: Nicholas Knize
> Priority: Blocker
> Labels: blocker
> Fix For: 6.0
>
> Attachments: LUCENE-7015.patch, LUCENE-7015.patch
>
>
> Follow on to LUCENE-6997: non GeoPoint* classes need to be refactored from
> existing spatial module to a new spatial-extras module. All dev-tools, build
> and project files will be updated to correctly reference and build the new
> module.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
