[
https://issues.apache.org/jira/browse/SOLR-8765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176577#comment-15176577
]
Jason Gerlowski commented on SOLR-8765:
---------------------------------------
I've been poking around in that code a bit recently, so I thought I might take
a look at your patch. It looked good to me.
The only tweak I'd suggest is that you might be able to move the
{{validateName}} IAE message String into SolrIdentifierValidator as a constant.
Ostensibly, that message is useful for anything that calls into SIV, so I'd
say there's value in extracting it to there (rather than having every caller
have their own slightly different error message).
Arguably, that's not related to this JIRA at all though. So take my suggestion
with a grain of salt.
Looks good to me!
> Enforce required parameters in SolrJ Collection APIs
> ----------------------------------------------------
>
> Key: SOLR-8765
> URL: https://issues.apache.org/jira/browse/SOLR-8765
> Project: Solr
> Issue Type: Improvement
> Reporter: Alan Woodward
> Fix For: 6.0
>
> Attachments: SOLR-8765.patch
>
>
> Several Collection API commands have required parameters. We should make
> these constructor parameters, to enforce setting these in the API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
