[
https://issues.apache.org/jira/browse/SOLR-8765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15189600#comment-15189600
]
Anshum Gupta commented on SOLR-8765:
------------------------------------
I am sure that the validator response was used to throw either the
SolrException of the IAE depending upon where it was. I am still not convinced
with that particular change of switching the return type and calling the single
validate method. Let us keep that as it was.
Also, returning boolean allows us to change the logging, or the behavior in
case of failed validation. We could still do that by catching the exception,
but why even return something on success, the original code returned nothing
from the validation method (void) and seems like your change partially reverts
back to the old code.
> Enforce required parameters in SolrJ Collection APIs
> ----------------------------------------------------
>
> Key: SOLR-8765
> URL: https://issues.apache.org/jira/browse/SOLR-8765
> Project: Solr
> Issue Type: Improvement
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Fix For: 6.1
>
> Attachments: SOLR-8765.patch, SOLR-8765.patch
>
>
> Several Collection API commands have required parameters. We should make
> these constructor parameters, to enforce setting these in the API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
