[
https://issues.apache.org/jira/browse/LUCENE-7093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15194150#comment-15194150
]
Martijn van Groningen commented on LUCENE-7093:
-----------------------------------------------
bq. In addField you return right away if the field had point values, but this
is dangerous because the field could also have e.g. doc values: (LatLonPoint
just recently started doing this), maybe we can add a test case for that?
Good point. I'll add a test for this.
bq. Or maybe MemoryIndex should just use BytesRef[], instead of BytesRefArray,
and sort that?
+1, lets simplify here. MemoryIndex only exists for a short amount of time and
then it is tossed away, so we shouldn't spend to0 much effort in space
efficient data structures here.
bq. Your visit function could be simplified too: just call the compare only
once, and if it crosses, visit all points (with doc and value);
If we there many values (lets say a couple of hundred values) for a single
field, wouldn't the current visit method be better. (because less comparisons
will need to happen). I have seen cases where fields had relatively a large
number of terms.
> MemoryIndex does not support points
> -----------------------------------
>
> Key: LUCENE-7093
> URL: https://issues.apache.org/jira/browse/LUCENE-7093
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Martijn van Groningen
> Attachments: LUCENE-7093.patch, LUCENE-7093.patch
>
>
> I realized this glancing at LUCENE-7091.
> I think this should have points support or else people cannot move off of the
> deprecated LegacyXXX encodings?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
