[ 
https://issues.apache.org/jira/browse/LUCENE-7093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15194230#comment-15194230
 ] 

Martijn van Groningen commented on LUCENE-7093:
-----------------------------------------------

bq. Also, I think the visit method only works in the 1D case ... for e.g. the 
2D case, I think it may be buggy because the byte[] values were sorted only by 
the first dimension?

I didn't realize that this was buggy in 2d case. I assumed that I was sorting 
the values correctly for any dimension, because LongPoint and friends pack 
multiple dimensions into a single BytesRef. Just curious, how would the sort 
then work?

bq. I feel like it's best to get a simple, correct, implementation in at first, 
and then worry about optimizing for the "many points in a single document" case 
later?

+1. I'll simplify the visitor method.

> MemoryIndex does not support points
> -----------------------------------
>
>                 Key: LUCENE-7093
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7093
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Assignee: Martijn van Groningen
>         Attachments: LUCENE-7093.patch, LUCENE-7093.patch
>
>
> I realized this glancing at LUCENE-7091.
> I think this should have points support or else people cannot move off of the 
> deprecated LegacyXXX encodings?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to