[
https://issues.apache.org/jira/browse/LUCENE-7145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15214193#comment-15214193
]
Robert Muir commented on LUCENE-7145:
-------------------------------------
I'll start looking at tests. I think we can apply the new polygon generators to
these methods directly as a start. Its at least more efficient than running
queries.
> We need only one set of polygon util methods
> --------------------------------------------
>
> Key: LUCENE-7145
> URL: https://issues.apache.org/jira/browse/LUCENE-7145
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
>
> LatLonPoint methods are calling {{*precise()}} methods such as
> rectCrossesPolyPrecise(). GeoPointMethods are calling {{*approx()}} methods
> such as rectCrossesPolyApprox().
> I don't understand why we have two versions of these methods, why one is
> approximate, why we would ever use that, etc.
> These geo methods are extremely expensive: we can't afford two copies. For
> example, in the case of these polygon methods, they are still missing direct
> tests. We need to remove one copy of these. I propose to remove the approx
> ones.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
