[
https://issues.apache.org/jira/browse/LUCENE-7145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15214619#comment-15214619
]
ASF subversion and git services commented on LUCENE-7145:
---------------------------------------------------------
Commit 70290d9c8e114ba8cf5d083d3c3c51db9bb87ce8 in lucene-solr's branch
refs/heads/branch_6x from [~rcmuir]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=70290d9 ]
LUCENE-7145: consolidate polygon range checks, tests, box usage. make cannot ->
must not consistent so we can test this stuff.
> We need only one set of polygon util methods
> --------------------------------------------
>
> Key: LUCENE-7145
> URL: https://issues.apache.org/jira/browse/LUCENE-7145
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
>
> LatLonPoint methods are calling {{*precise()}} methods such as
> rectCrossesPolyPrecise(). GeoPointMethods are calling {{*approx()}} methods
> such as rectCrossesPolyApprox().
> I don't understand why we have two versions of these methods, why one is
> approximate, why we would ever use that, etc.
> These geo methods are extremely expensive: we can't afford two copies. For
> example, in the case of these polygon methods, they are still missing direct
> tests. We need to remove one copy of these. I propose to remove the approx
> ones.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
