[ 
https://issues.apache.org/jira/browse/LUCENE-7152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221796#comment-15221796
 ] 

David Smiley commented on LUCENE-7152:
--------------------------------------

+1 to your patch Nick.

bq. I think in this day and age it is reasonable to treat this stuff as a core 
capability

If highlighting, suggesting, etc. aren't a "core" part of search (thus Lucene 
core) yet spatial somehow is... well, ... I'm rendered speechless.  Spatial is 
cool and important; many (but not all!) users want it.  But this is so for just 
about everything else we have.  I'm trying to keep things organized.  It'd be 
confusing to have some spatial in core and some not in core.  And if somehow it 
makes things harder for spandbox particularly, I think that's no reason to base 
decisions on.

bq. "spatial module madness" 

I don't think the current situation is "madness" but you do... okay... yet 
isn't it self-imposed?  I was always a fan of keeping all our spatial code in 
one spatial module.  Clearly that's simple for users to grok too.

> Refactor lucene-spatial GeoUtils to core
> ----------------------------------------
>
>                 Key: LUCENE-7152
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7152
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Nicholas Knize
>         Attachments: LUCENE-7152.patch, LUCENE-7152.patch
>
>
> {{GeoUtils}} contains a lot of common spatial mathematics that can be reused 
> across multiple packages. As discussed in LUCENE-7150 this issue will 
> refactor GeoUtils to a new {{o.a.l.util.geo}} package in core that can be the 
> home for other reusable spatial utility classes required by field and query 
> implementations. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to