[
https://issues.apache.org/jira/browse/LUCENE-7163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicholas Knize updated LUCENE-7163:
-----------------------------------
Attachment: LUCENE-7163.patch
Patch ready for review:
* refactors {{GeoRect}} from spatial module to {{o.a.l.geo.Rectangle}} in core
module
* refactors {{Polygon}} from spatial module to {{o.a.l.geo.Polygon}} in core
module
* refactors {{TestGeoUtils}} from spatial module to core tests module
* refactors {{GeoTestUtil}} from spatial module to test-framework module
* Moves encoding tests from {{TestGeoUtils}} to new {{TestGeoEncodingUtils}} in
spatial module
* TODO: requires a new (temporary) duplicated TOLERANCE variable in {{Polygon}}
that currently lives in {{GeoEncodingUtils}}. See LUCENE-7165 for reason. This
will be removed in 7165.
> Refactor GeoRect and Polygon to core
> ------------------------------------
>
> Key: LUCENE-7163
> URL: https://issues.apache.org/jira/browse/LUCENE-7163
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Nicholas Knize
> Attachments: LUCENE-7163.patch
>
>
> {{o.a.l.spatial.util.GeoRect}} and {{o.a.l.spatial.util.Polygon}} are
> reusable classes across multiple lucene modules. It makes sense for them to
> be moved to the {{o.a.l.geo}} package in the core module so they're exposed
> across multiple modules.
> {{GeoRect}} should also be refactored to something more straightforward, like
> {{Rectangle}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
