[ 
https://issues.apache.org/jira/browse/SOLR-8959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235200#comment-15235200
 ] 

Christine Poerschke commented on SOLR-8959:
-------------------------------------------

bq. (I suspect the only reason this wasn't done initially in SOLR-5730 is 
because maybe the patch predates the creation of SolrCloudTestCase?)

That's correct. SOLR-5730 was first half of February and SOLR-8758 i.e. 
[SolrCloudTestCase.java|https://github.com/apache/lucene-solr/blob/master/solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java]
 was second half of February this year.

> TestMiniSolrCloudCluster.testSegmentTerminateEarly should be refactored into 
> it's own SolrCloudTestCase subclass
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-8959
>                 URL: https://issues.apache.org/jira/browse/SOLR-8959
>             Project: Solr
>          Issue Type: Test
>            Reporter: Hoss Man
>
> The functionality tested in testSegmentTerminateEarly (and the helper code in 
> "SegmentTerminateEarlyTestState") should really belong in it's own test 
> class, which can subclass SolrCloudTestCase.
> (I suspect the only reason this wasn't done initially in SOLR-5730 is because 
> maybe the patch predates the creation of SolrCloudTestCase?)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to