[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated LUCENE-5325:
----------------------------------
Attachment: LUCENE-5325.patch
Updated patch, nuking setScorer() and exists().
There's a bit of hinky logic around creating sorts now, because FieldComparator
separates out setNextReader() and setScorer(), but it is at least contained.
We still need to pass in a Scorer somewhere though, so that scores are
available to the leaf values.
Another option would be to pull the Scorer logic back into the expressions
module itself, but I think having a generic DoubleValues.SCORES instance is
going to be useful in lots of situations; plus it means that all of the sorting
logic is in DoubleValuesProducer itself.
Also adds a test for converting a DoubleValuesSource into a generic ValueSource
(not the other way round, which I had originally put in and isn't needed yet!)
> Move ValueSource and FunctionValues under core/
> -----------------------------------------------
>
> Key: LUCENE-5325
> URL: https://issues.apache.org/jira/browse/LUCENE-5325
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
> Reporter: Shai Erera
> Attachments: LUCENE-5325.patch, LUCENE-5325.patch
>
>
> Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs
> which exist under the queries/ module. That causes any module which wants to
> depend on these APIs (but not necessarily on any of their actual
> implementations!), to depend on the queries/ module. If we move these APIs
> under core/, we can eliminate these dependencies and add some mock impls for
> testing purposes.
> Quoting Robert from LUCENE-5298:
> {quote}
> we should eliminate the suggest/ dependencies on expressions and queries, the
> expressions/ on queries, the grouping/ dependency on queries, the spatial/
> dependency on queries, its a mess.
> {quote}
> To add to that list, facet/ should not depend on queries too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
