[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated LUCENE-5325:
----------------------------------
Attachment: LUCENE-5325.patch
You're right, it is unrelated, and there's a way around it, I just needed to
get away from thinking in the mode of the previous API. So thanks for the
push-back :-)
Here's a new patch which cuts over expressions, facets and suggest. There's
one new method on DoubleValuesSource and LongValuesSource, for retrieving a
bitset marking which docs actually have a value here, which is required by the
facet counting code. Field wrappers just forward to
DocValues.getDocsWithField(), and everything else returns a MatchAllBits for
now. Ideally, expressions would AND together the bitsets from all child
variables, but that can be done in a followup once I've found the methods to
actually do that efficiently...
I think this is good enough to start with? Grouping, join and queries modules
are going to be more complicated I think, so should be done in a separate JIRA.
And this patch is already pretty big, and can probably be broken up into
separate commits for each module.
> Move ValueSource and FunctionValues under core/
> -----------------------------------------------
>
> Key: LUCENE-5325
> URL: https://issues.apache.org/jira/browse/LUCENE-5325
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
> Reporter: Shai Erera
> Attachments: LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch,
> LUCENE-5325.patch
>
>
> Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs
> which exist under the queries/ module. That causes any module which wants to
> depend on these APIs (but not necessarily on any of their actual
> implementations!), to depend on the queries/ module. If we move these APIs
> under core/, we can eliminate these dependencies and add some mock impls for
> testing purposes.
> Quoting Robert from LUCENE-5298:
> {quote}
> we should eliminate the suggest/ dependencies on expressions and queries, the
> expressions/ on queries, the grouping/ dependency on queries, the spatial/
> dependency on queries, its a mess.
> {quote}
> To add to that list, facet/ should not depend on queries too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
