[ 
https://issues.apache.org/jira/browse/LUCENE-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012737#comment-13012737
 ] 

Uwe Schindler commented on LUCENE-3001:
---------------------------------------

bq. The default precisionStep should not have to have to be standardized – solr 
can always set it in the constructor.

Thats my opinion, too. I was just confused about the initial commit where it 
was somehow redefined to 8 in Lucene.

The current ptoblem with NumericField is simply that you don't get one back 
when you do a Document.getField() on the search results. And this is why we did 
the toString() variant in 2.9.

Mike's proposal is in my opinion the best one, make FieldsReader return a 
NumericField if the bit is set. Then we can even store it the ByteBuffer-like 
way (how solr does at the moment). The encoding is then left over to the 
implementation details in Lucene. Just like the encoding of String fields is 
internal to the field type.

When we change the codec API to also handle stored fields, we maybe should also 
make the abstract Field API that communicates with the indexer simply pass a 
BytesRef to the indexer, just like TermToBytesRefAttribute on the indexing 
side. NumericField would simply implement this API different than StringField 
or BinaryField (or how we would call them).

> Add TrieFieldHelper lucene so we can write solr compatible Trie* fields w/o 
> solr dependency
> -------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3001
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3001
>             Project: Lucene - Java
>          Issue Type: New Feature
>            Reporter: Ryan McKinley
>            Priority: Minor
>         Attachments: LUCENE-3001-TrieFieldHelper.patch
>
>
> The solr support for numeric fields writes the stored value as binary vs the 
> lucene NumericField
> We should move this logic to a helper class in lucene core so that libraries 
> that do not depend on solr can write TrieFields that solr can read.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to