[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15339971#comment-15339971 ]
Hrishikesh Gadre commented on SOLR-7374: ---------------------------------------- [~varunthacker] bq. Let's stick to the current model of reading from the solr.xml file and defaulting to local if its not defined ? I am not sure if you realize the problem here. This is the code snippet that I am wondering about, https://github.com/apache/lucene-solr/blob/a4455a4b14f2bf947db1136f9d5fc7d0d88d32ef/solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java#L1324 This particular code is invoked as a callback (and not directly as part of handling a user request). https://github.com/apache/lucene-solr/blob/a4455a4b14f2bf947db1136f9d5fc7d0d88d32ef/solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java#L1182 So in case there are multiple repositories configured, we need a way to configure *which* repository to use. In case of backup/restore API - this configuration parameter was passed by the user. I wonder if we need to add a config param in the ReplicationHandler ? > Backup/Restore should provide a param for specifying the directory > implementation it should use > ----------------------------------------------------------------------------------------------- > > Key: SOLR-7374 > URL: https://issues.apache.org/jira/browse/SOLR-7374 > Project: Solr > Issue Type: Bug > Reporter: Varun Thacker > Assignee: Mark Miller > Fix For: 6.2 > > Attachments: SOLR-7374.patch, SOLR-7374.patch, SOLR-7374.patch, > SOLR-7374.patch, SOLR-7374.patch, SOLR-7374.patch, SOLR-7374.patch > > > Currently when we create a backup we use SimpleFSDirectory to write the > backup indexes. Similarly during a restore we open the index using > FSDirectory.open . > We should provide a param called {{directoryImpl}} or {{type}} which will be > used to specify the Directory implementation to backup the index. > Likewise during a restore you would need to specify the directory impl which > was used during backup so that the index can be opened correctly. > This param will address the problem that currently if a user is running Solr > on HDFS there is no way to use the backup/restore functionality as the > directory is hardcoded. > With this one could be running Solr on a local FS but backup the index on > HDFS etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org