[ https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15340439#comment-15340439 ]
Hrishikesh Gadre commented on SOLR-7374: ---------------------------------------- [~varunthacker] bq. Alternatively how do you feel about forcing a default repository if multiple repos are configured? Currently if there is just 1 we make that default but when there are multiple repositories we don't necessarily need to provide a default. Yes we can force the user to have a default repository if multiple repos are configured. But it seems to me that the code under consideration is added as part of SOLR-561 (i.e. Solr replication). Do we need to incorporate these changes in the replication work-flow? My gut feeling is that we shouldn't make any changes to this code as part of this JIRA. bq. I feel the first point should be part of this Jira . We can then say this patch effectively solves makes the repository interface work for both standalone and cloud. Based on JIRA description, I thought the requirement for this JIRA is to support core level backup/restore. But I am OK with repurposing this JIRA to cover Solr cloud as well. Its just that the patch will grow in size :) I generally prefer to keep patch short which makes it easier to review and test. But if you are OK with larger patch, I can resubmit it. Let me know. > Backup/Restore should provide a param for specifying the directory > implementation it should use > ----------------------------------------------------------------------------------------------- > > Key: SOLR-7374 > URL: https://issues.apache.org/jira/browse/SOLR-7374 > Project: Solr > Issue Type: Bug > Reporter: Varun Thacker > Assignee: Mark Miller > Fix For: 6.2 > > Attachments: SOLR-7374.patch, SOLR-7374.patch, SOLR-7374.patch, > SOLR-7374.patch, SOLR-7374.patch, SOLR-7374.patch, SOLR-7374.patch > > > Currently when we create a backup we use SimpleFSDirectory to write the > backup indexes. Similarly during a restore we open the index using > FSDirectory.open . > We should provide a param called {{directoryImpl}} or {{type}} which will be > used to specify the Directory implementation to backup the index. > Likewise during a restore you would need to specify the directory impl which > was used during backup so that the index can be opened correctly. > This param will address the problem that currently if a user is running Solr > on HDFS there is no way to use the backup/restore functionality as the > directory is hardcoded. > With this one could be running Solr on a local FS but backup the index on > HDFS etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org