[
https://issues.apache.org/jira/browse/SOLR-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019377#comment-13019377
]
Tommaso Teofili commented on SOLR-2436:
---------------------------------------
Hello Koji,
your patch seems fine to me from the functional point of view.
Just, I don't think the SolrUIMAConfigurationReader should be emptied, I
wouldn't remove it preferring to assign to it the simple responsibility of
reading args without the previous explicit Node traversing but, as you did,
using the "Solr way".
I also made some fixes to remove warning while getting objects from the
NamedList.
> move uimaConfig to under the uima's update processor in solrconfig.xml
> ----------------------------------------------------------------------
>
> Key: SOLR-2436
> URL: https://issues.apache.org/jira/browse/SOLR-2436
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 3.1
> Reporter: Koji Sekiguchi
> Priority: Minor
> Attachments: SOLR-2436-3.patch, SOLR-2436.patch, SOLR-2436.patch,
> SOLR-2436.patch, SOLR-2436_2.patch
>
>
> Solr contrib UIMA has its config just beneath <config>. I think it should
> move to uima's update processor tag.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
